NPE (service is null) in StreamManagementIOProcessor.processCommand (#1536)

Wojciech Kapcia (Tigase) opened 11 months ago

[2024-03-24 15:49:03:678] [SEVERE  ] [              in_4-c2s ] AbstractMessageReceiver$QueueListener.run(): [in_4-c2s] Exception during packet processing: from=sess-man@ip-172-31-38-91.us-west-2.compute.internal, to=c2s@ip-172-31-38-91.us-west-2.compute.internal/172.18.0.3_5222_89.31.247.193_1024, serverAuthorisedStanzaFrom=Optional.empty, DATA=<iq id="dfea3188-01a6-47d3-83dc-3e3e1cef5ed2" to="c2s@ip-172-31-38-91.us-west-2.compute.internal/172.18.0.3_5222_89.31.247.193_1024" type="set" from="sess-man@ip-172-31-38-91.us-west-2.compute.internal"><command xmlns="http://jabber.org/protocol/commands" node="STREAM_MOVED"><x xmlns="jabber:x:data" type="submit"><field var="cmd"><value>stream-moved</value></field><field var="cmd"><value>stream-moved</value></field><field var="new-conn-jid"><value>c2s@ip-172-31-38-91.us-west-2.compute.internal/172.18.0.3_5222_89.31.247.193_1025</value></field><field var="send-response"><value>true</value></field></x></command></iq>, SIZE=622, XMLNS=null, PRIORITY=NORMAL, PERMISSION=NONE, TYPE=set, STABLE_ID=null
java.lang.NullPointerException: Cannot invoke "tigase.xmpp.XMPPIOService.getSessionData()" because "service" is null
	at tigase.server.xmppclient.StreamManagementIOProcessor.processCommand(StreamManagementIOProcessor.java:333)
	at tigase.server.xmppclient.ClientConnectionManager.processCommand(ClientConnectionManager.java:893)
	at tigase.server.xmppclient.ClientConnectionManager.processPacket(ClientConnectionManager.java:129)
	at tigase.server.AbstractMessageReceiver$QueueListener.run(AbstractMessageReceiver.java:1398)

Referenced from commit 10 months ago

Fixed possible NPE in StreamManagment resumption when during resumption stream connection was closed #1536

Andrzej Wójcik (Tigase) committed 10 months ago

dd7622af

Andrzej Wójcik (Tigase) changed state to 'In Progress' 10 months ago

Previous Value	Current Value
Open	In Progress

Andrzej Wójcik (Tigase) changed state to 'In QA' 10 months ago

Previous Value	Current Value
In Progress	In QA

Andrzej Wójcik (Tigase) commented 10 months ago

I've added check to ensure that session (connection) that is trying to resume XMPP session still exists. If it doesn't it means connection was closed/lost and we should ignore resumption request.

Wojciech Kapcia (Tigase) changed state to 'Closed' 10 months ago

Previous Value	Current Value
In QA	Closed

Type	Bug
Priority	If you are bored
Assignee	Andrzej Wójcik (Tigase)
Version	none
Sprints	n/a
Customer	n/a

Iterations

tigase-server-8.5.0 Open

Issue Votes (0)

Watchers (3)

Reference

tigase/_server/server-core#1536